forked from adrienverge/localstripe
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Fatsoma payment process #1
Open
biinari
wants to merge
36
commits into
master
Choose a base branch
from
fix/fatsoma_payments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,219
−428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add API for webhooks following stripe's API. Keep existing /_config/webhooks for registering webhooks with predefined secrets.
When localstripe is injected into the page, it may not be the last script element. Find a script that matches a domain followed by js.stripe.com/v3 Also allow starting with '//', 'http://' or 'https://'
Give extra data to Bad Request errors to explain which parameter is missing or invalid.
luqman
approved these changes
May 6, 2021
Allow Stripe to be instantiated with the 'new' operator.
canMakePayment resolves null to indicate no support for any paymentRequest.
Support creating Elements of types: card, cardNumber, cardExpiry, cardCvc.
Add off() to remove event listener
Add extra methods for Element: blur, focus, clear, update. Trigger extra events: ready, blur, focus.
biinari
force-pushed
the
fix/fatsoma_payments
branch
from
May 7, 2021 04:01
f701440
to
fd47d85
Compare
Pass event object to listeners for change event
Filter customers by email if param is present
Add created, succeeded, payment_failed, canceled webhooks for payment_intent
Add payment_method.attached, payment_method.detached webhook events
Calls confirmCardPayment() with option handleNextAction: false
Payment flow may be at confirmation step
At debug level, log when sending a webhook.
Move dockerfile from README to its own Dockerfile
biinari
force-pushed
the
fix/fatsoma_payments
branch
from
October 6, 2021 02:55
31b39e1
to
151c42c
Compare
Allow specifying a standard and stripe connect webhook through env vars: WEBHOOK_URL WEBHOOK_SIGNING_SECRET CONNECT_WEBHOOK_URL CONNECT_WEBHOOK_SIGNING_SECRET Or through vault using AWS IAM authentication, needing these env vars: VAULT_ADDR VAULT_ROLE ENVIRONMENT will look at `secret/fatsoma/${ENVIRONMENT}/api/payment` for keys: stripe_webhook_url stripe_webhook_signing_secret stripe_connect_webhook_url stripe_connect_webhook_signing_secret
Allow health check to use /_status without auth
biinari
force-pushed
the
fix/fatsoma_payments
branch
from
October 6, 2021 03:00
151c42c
to
f98d044
Compare
Prevent memory growth by deleting PaymentIntent after we have finished using it.
Disable disk loading and saving
biinari
force-pushed
the
fix/fatsoma_payments
branch
from
November 11, 2021 14:21
2d3d722
to
26309ef
Compare
Update to aws ecr get-login-password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/174342202
This work should be cherry-picked out into multiple PRs to request
changes upstream. For brevity, all changes are being made for supporting
Fatsoma here.
/v1/webhook_endpoints
. Keepexisting
/_config/webhooks
for registering webhooks with specifiedsecrets.
LOCALSTRIPE_SOURCE
in js to work when not the last scriptelement in the page.
/v1/accounts
and standard account at/v1/account
400: Bad Request
errors to indicate which paramsare missing or invalid.